chore: add colour to the advisory generation output.#109
Merged
Conversation
Unifex
requested review from
G-Rath,
jonholdsworth,
justineleonard,
lilianasummers,
nzlaura and
simonchisnall-online
Unifex
force-pushed
the
chore/colourize-generate-osv-advisories
branch
from
8cfdbdc to
8093324
Compare
G-Rath
requested changes
Jul 16, 2025
G-Rath
left a comment
G-Rath
left a comment
Collaborator
There was a problem hiding this comment.
good stuff - I'm on the fence about the specific colors as e.g. it's not really a success that we've patched an advisory because we don't want to be doing that, but lets roll with what you've got for now.
I think it would be best if we used f-strings where possible instead of appending so if you could change that it'd be great (though I'm ok leaving the "skipping patching" message if that turns out to be a pain having an f-string in an f-string...)
simonchisnall-online
approved these changes
Jul 17, 2025
Unifex
force-pushed
the
chore/colourize-generate-osv-advisories
branch
from
3acf654 to
1f6a712
Compare
G-Rath
reviewed
Aug 20, 2025
* pyproject.toml ordering * create a helper class for Text * refactor to use Text.*() helpers
Unifex
force-pushed
the
chore/colourize-generate-osv-advisories
branch
from
febb921 to
43f7092
Compare
Collaborator
Author
|
Woot! Super Green! |
jonholdsworth
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find the output from the Advisory generation to be an unreadable wall of text.
This adds a scattering of colour to the notices for SAs that have had an action applied to them.
This is manage through the addition of Colorama. I selected this one as it manages the colours and styles while taking into account the platform it's run on, is actively maintained, and has been around for more than a decade.
I note that the
poetry.lockhas an unexpected removal. Could this be because it is included via the new Colourama?